-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Only ship x-pack library code with artifacts #18548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts.
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
run exhaustive tests |
For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack.
|
run exhaustive tests |
💚 Build Succeeded
History
|
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
@Mergifyio backport 8.19 9.1 9.2 9.3 |
✅ Backports have been createdDetails
|
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0)
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0) # Conflicts: # rakelib/artifacts.rake
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0)
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0)
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0) Co-authored-by: Cas Donoghue <[email protected]>
* Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0) Co-authored-by: Cas Donoghue <[email protected]>
…18592) * Only ship x-pack library code with artifacts (#18548) * Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0) # Conflicts: # rakelib/artifacts.rake * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]>
…#18591) * Only ship x-pack library code with artifacts (#18548) * Only ship x-pack library code with artifacts This commit updates artifact generation to *only* include x-pack files which are needed at runtime for consumers of an artifact. Previously *all* files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts. * add config in observabilitySRE artifact For observabilitySRE container, add in fips config. Previously this was bulk included with EVERY file under x-pack. (cherry picked from commit bd4cec0) * Ship x-pack/modules with 8.19 In the 8.19 logstash release track the x-pack/modules directory is required in addition to x-pack/lib in build artifacts. --------- Co-authored-by: Cas Donoghue <[email protected]>
Release notes
Clean up unused files in
x-packfor logstash artifacts.What does this PR do?
This commit updates artifact generation to only include x-pack files which are needed at runtime for consumers of an artifact. Previously all files (including build/test/conf) were shipped which are unused at runtime and clutter up artifacts.
Why is it important/What is the impact to the user?
Clean up artifacts such that unused files are not installed.
Related issues